Skip to content

[Release/7.0-staging] Allow GetILFunctionBody for dynamic methods #87598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davmason
Copy link
Contributor

Port #87530 to 7.0

Customer Impact

We introduced a regression in 7.0 that prevents ICorProfiler implementations from being able to request IL for dynamic methods. This was reported by a 3rd party profiler maintainer and is preventing their product from working on 7.0.

Testing

Privates of the fix were provided to the customer and verified that they fix the issue.

Risk

Low risk, it does not introduce any known risk.

@davmason davmason added this to the 7.0.x milestone Jun 15, 2023
@davmason davmason requested a review from a team June 15, 2023 07:19
@davmason davmason self-assigned this Jun 15, 2023
@ghost
Copy link

ghost commented Jun 15, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Port #87530 to 7.0

Customer Impact

We introduced a regression in 7.0 that prevents ICorProfiler implementations from being able to request IL for dynamic methods. This was reported by a 3rd party profiler maintainer and is preventing their product from working on 7.0.

Testing

Privates of the fix were provided to the customer and verified that they fix the issue.

Risk

Low risk, it does not introduce any known risk.

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr

Milestone: 7.0.x

@davmason davmason added the Servicing-consider Issue for next servicing release review label Jun 15, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x. please get a code review

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 20, 2023
@rbhanda rbhanda modified the milestones: 7.0.x, 7.0.10 Jun 20, 2023
@carlossanlop
Copy link
Contributor

carlossanlop commented Jul 10, 2023

@davmason - Reminder: Code Complete for the August Release is tomorrow Monday July 10th. If you intend to include this fix in that release, please make sure to merge it before 4pm because that's when I'll start the staging merge process into internal.

@davmason davmason merged commit f865846 into dotnet:release/7.0-staging Jul 10, 2023
@radical radical mentioned this pull request Aug 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants