Skip to content

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jun 12, 2023

This sets FEATURE_EVENT_TRACE on non-Windows platforms as well, such that GC counter information is tracked and provided when requested.

This is only enough to enable the counter tracking (#87325). It does not fully enable event tracing via EventPipe on non-Windows.

I manually verified by running dotnet-counters monitor. The automated tests just verify the counters can be retrieved - which they could before, but some of them were just always 0.

Pulling in whatever is under FEATURE_EVENT_TRACE seems to be about +25kB on my helloworld app.

This sets FEATURE_EVENT_TRACE on non-Windows platforms as well, such that GC counter
information is tracked and provided when requested.

This does not fully enable runtime event tracing via EventPipe on non-Windows.
@ghost
Copy link

ghost commented Jun 12, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This sets FEATURE_EVENT_TRACE on non-Windows platforms as well, such that GC counter information is tracked and provided when requested.

This is only enough to enable the counter tracking (#87325). It does not fully enable event tracing via EventPipe on non-Windows.

I manually verified by running dotnet-counters monitor. The automated tests just verify the counters can be retrieved - which they could before, but some of them were just always 0.

Author: elinor-fung
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agocke
Copy link
Member

agocke commented Jun 13, 2023

Pulling in whatever is under FEATURE_EVENT_TRACE seems to be about +25kB on my helloworld app.

Is that with the EventSource support enabled via feature flag? Otherwise I thought we managed to avoid pulling in the event source stuff in helloworld.

@MichalStrehovsky
Copy link
Member

Pulling in whatever is under FEATURE_EVENT_TRACE seems to be about +25kB on my helloworld app.

Is that with the EventSource support enabled via feature flag? Otherwise I thought we managed to avoid pulling in the event source stuff in helloworld.

Only event pipe is separated out into an opt in library. We don't separate the event source support. I haven't looked how feasible it would be to put it into a separate static library that we could disable if event source is not enabled, but at 25 kB it's not worth too much effort.

@elinor-fung
Copy link
Member Author

It is not with EventSource support enabled via feature flag. This enables code in the GC (currently enabled on Windows always) that keeps track of information that gets returned in counters - unlike eventpipe itself, we don't have separate enabled/disabled libs for the GC.

@LakshanF LakshanF merged commit 94a1208 into dotnet:main Jun 13, 2023
@elinor-fung elinor-fung deleted the nativeaot-counters-unix branch June 27, 2023 17:54
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants