JIT: Allow RBO for known relops even without a dominator #86774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay the check for whether there is a dominator to the case where we're actually going to try to infer from it.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsDelay the check for whether there is a dominator to the case where we're actually going to try to infer from it. Hit some spurious diffs in a local change due to this difference.
|
Member
Author
|
Suprisingly large diffs (mainly in tests, but also a fair bit in libraries.pmi). cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
May 26, 2023
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Odd that assertion prop was not handling these.
Member
Author
|
Failures are known according to build analysis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay the check for whether there is a dominator to the case where we're actually going to try to infer from it.
Hit some spurious diffs in a local change due to this difference.