Skip to content

QUIC ALPN list narrowing down scenario test #86659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 22, 2023
Merged

QUIC ALPN list narrowing down scenario test #86659

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
01dbb52
Added necessary test for ALPN Change on QUIC
liveans May 6, 2023
28a2efe
Alpn test fix
liveans May 23, 2023
9ca6e7c
Update src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListen…
liveans May 23, 2023
77ec3bd
Review feedback and marking failure case with active issue
liveans May 24, 2023
ab28064
Change test to theory and add not existing data as alpn
liveans May 24, 2023
b90b872
Review Feedback
liveans May 25, 2023
ac8199a
fix compilation
liveans May 25, 2023
87e7c7a
Delete ActiveIssue attribute
liveans Jun 21, 2023
cbcd949
Put ActiveIssue back
liveans Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,5 +372,103 @@ await Task.WhenAll(
await connection.DisposeAsync();
}).WaitAsync(TimeSpan.FromSeconds(5)));
}

[Fact]
public async Task Listener_AlpnNarrowingDown_Success()
{
using CancellationTokenSource testTimeoutCts = new CancellationTokenSource(PassingTestTimeout);
CancellationToken timeoutToken = testTimeoutCts.Token;

var listenerOptions = new QuicListenerOptions()
{
ListenEndPoint = new IPEndPoint(IPAddress.Loopback, 0),
ApplicationProtocols = new List<SslApplicationProtocol>()
{
new SslApplicationProtocol("foo"),
new SslApplicationProtocol("bar"),
new SslApplicationProtocol("test"),
},
ConnectionOptionsCallback = (_, _, _) =>
{
// Narrowing down alpn list to more specific.
var options = CreateQuicServerOptions();
options.ServerAuthenticationOptions.ApplicationProtocols = new()
{
new SslApplicationProtocol("bar"),
new SslApplicationProtocol("test"),
};
return ValueTask.FromResult(options);
}
};
await using QuicListener listener = await CreateQuicListener(listenerOptions);

// Successful connection with bar ALPN
QuicClientConnectionOptions clientOptions1 = CreateQuicClientOptions(listener.LocalEndPoint);
clientOptions1.ClientAuthenticationOptions.ApplicationProtocols = new()
{
new SslApplicationProtocol("foo"),
new SslApplicationProtocol("bar"),
};
ValueTask<QuicConnection> connectTask1 = CreateQuicConnection(clientOptions1);
await using QuicConnection serverConnection1 = await listener.AcceptConnectionAsync().AsTask().WaitAsync(timeoutToken);
await using QuicConnection clientConnection1 = await connectTask1.AsTask().WaitAsync(timeoutToken);

Assert.Equal(new SslApplicationProtocol("bar"), clientConnection1.NegotiatedApplicationProtocol);

// Successful connection with test ALPN
QuicClientConnectionOptions clientOptions2 = CreateQuicClientOptions(listener.LocalEndPoint);
clientOptions2.ClientAuthenticationOptions.ApplicationProtocols = new()
{
new SslApplicationProtocol("foo"),
new SslApplicationProtocol("test"),
};
ValueTask<QuicConnection> connectTask2 = CreateQuicConnection(clientOptions2);
await using QuicConnection serverConnection2 = await listener.AcceptConnectionAsync().AsTask().WaitAsync(timeoutToken);
await using QuicConnection clientConnection2 = await connectTask2.AsTask().WaitAsync(timeoutToken);

Assert.Equal(new SslApplicationProtocol("test"), clientConnection2.NegotiatedApplicationProtocol);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/86701")]
[Theory]
[InlineData("foo")]
[InlineData("not_existing")]
public async Task Listener_AlpnNarrowingDown_Failure(string alpn)
{
using CancellationTokenSource testTimeoutCts = new CancellationTokenSource(PassingTestTimeout);
CancellationToken timeoutToken = testTimeoutCts.Token;

var listenerOptions = new QuicListenerOptions()
{
ListenEndPoint = new IPEndPoint(IPAddress.Loopback, 0),
ApplicationProtocols = new List<SslApplicationProtocol>()
{
new SslApplicationProtocol("foo"),
new SslApplicationProtocol("bar"),
new SslApplicationProtocol("test"),
},
ConnectionOptionsCallback = (_, _, _) =>
{
// Narrowing down alpn list to more specific.
var options = CreateQuicServerOptions();
options.ServerAuthenticationOptions.ApplicationProtocols = new()
{
new SslApplicationProtocol("bar"),
new SslApplicationProtocol("test"),
};
return ValueTask.FromResult(options);
}
};
await using QuicListener listener = await CreateQuicListener(listenerOptions);

QuicClientConnectionOptions clientOptions = CreateQuicClientOptions(listener.LocalEndPoint);
clientOptions.ClientAuthenticationOptions.ApplicationProtocols = new()
{
new SslApplicationProtocol(alpn),
};
ValueTask<QuicConnection> connectTask = CreateQuicConnection(clientOptions);
await Assert.ThrowsAsync<AuthenticationException>(() => listener.AcceptConnectionAsync().AsTask().WaitAsync(timeoutToken));
await Assert.ThrowsAsync<AuthenticationException>(() => connectTask.AsTask().WaitAsync(timeoutToken));
}
}
}