-
Notifications
You must be signed in to change notification settings - Fork 5k
Unify parsing part of BigInteger with CoreLib #85978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
fee2893
Move NumberBuffer to common
huoyaoyuan 587589d
Add common files for parsing and formatting
huoyaoyuan b00e235
Move TryParseNumber and dependents to common
huoyaoyuan 80fd5a5
Use Common for BigInteger parsing and fix exponent
huoyaoyuan a3d74ca
Adapt hex parsing
huoyaoyuan f8f5bb8
Cleanup unused parsing code
huoyaoyuan d5c7099
Move FormatProvider.Number to System.Runtime.Numerics
huoyaoyuan fe2f087
Cleanup BigNumber.Parse calls
huoyaoyuan 8387024
Move BigNumber to Number.BigInteger
huoyaoyuan bcc70e3
Remove Formatting.Common for PR
huoyaoyuan 25b8232
Merge branch 'main' into numerics-format-1
huoyaoyuan 4a65ce6
Merge branch 'main'
huoyaoyuan f888f46
Update formatting code in CoreLib
huoyaoyuan 3637bfd
Update TryParseBigInteger
huoyaoyuan 4c1f638
BinaryNumberToBigInteger
huoyaoyuan b59c05f
HexNumberToBigInteger
huoyaoyuan 45d04c7
Cleanup unused parsing code in FormatProvider.Number
huoyaoyuan b879de2
Revert hex parsing
huoyaoyuan 712e5e1
Adapt binary with new parsing
huoyaoyuan df37400
Reapply hex fix
huoyaoyuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
378 changes: 378 additions & 0 deletions
378
src/libraries/Common/src/System/Number.Parsing.Common.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.