Skip to content

Conversation

@SingleAccretion
Copy link
Contributor

Please refer to the individual commits messages for the set of changes.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels May 3, 2023
@ghost
Copy link

ghost commented May 3, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Please refer to the individual commits messages for the set of changes.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion SingleAccretion force-pushed the No-Field-Quirks-Upstream branch from 5c56253 to 4335423 Compare May 3, 2023 22:25
One tiny regression in a Regex method due to us not clearing GLOB_REF where not needed.
About neutral in improvements and regressions.

Both come from the differences in the handling of unused indirs and NULLCHECK nodes.
@SingleAccretion SingleAccretion force-pushed the No-Field-Quirks-Upstream branch from 4335423 to 8febc20 Compare May 3, 2023 22:48
@SingleAccretion SingleAccretion marked this pull request as ready for review May 4, 2023 00:44
@SingleAccretion
Copy link
Contributor Author

Diffs.

@dotnet/jit-contrib

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit e61e022 into dotnet:main May 6, 2023
@SingleAccretion SingleAccretion deleted the No-Field-Quirks-Upstream branch May 6, 2023 14:54
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants