Skip to content

Delete OBJ(LCL_ADDR) args handling from local morph ref counting #85544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2023
Merged

Delete OBJ(LCL_ADDR) args handling from local morph ref counting #85544

merged 2 commits into from
Apr 30, 2023

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 28, 2023 •
edited
Loading

No longer needed.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 28, 2023
@ghost
Copy link

ghost commented Apr 28, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Apr 29, 2023 •
edited
Loading

DIiffs.

There are a few regressions, but the TP diffs should outweigh that by a lot: 0.3% - 0.4% wins in MinOpts, 0.2%-0.3% in FullOpts.

@dotnet/jit-contrib

@SingleAccretion SingleAccretion marked this pull request as ready for review April 29, 2023 12:54
@SingleAccretion SingleAccretion mentioned this pull request Apr 30, 2023
Merged
AndyAyersMS
AndyAyersMS approved these changes Apr 30, 2023
View reviewed changes
@AndyAyersMS AndyAyersMS merged commit 1b28b1c into dotnet:main Apr 30, 2023
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Apr 30, 2023

@SingleAccretion, thanks.

@SingleAccretion SingleAccretion deleted the No-Obj-LclMorph branch May 1, 2023 15:14
@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SingleAccretion @AndyAyersMS