[release/7.0-staging] [native-library] If a dllimport is specified with an absolute path, look for it first #85270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook for it first The unmanaged native library probing documentation says to try absolute paths without variations https://learn.microsoft.com/en-us/dotnet/core/dependency-loading/default-probing#unmanaged-native-library-probing
github-actions
bot
requested review from
lambdageek,
thaystg and
vargaz
as code owners
ghost
added
the
|
Tagging subscribers to this area: Issue DetailsBackport of #85255 to release/7.0-staging /cc @lambdageek Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
This was referenced Apr 24, 2023
rbhanda
added
Servicing-approved
Member
Member
thaystg
approved these changes
Apr 27, 2023
Member
|
Failures are known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #85255 to release/7.0-staging
/cc @lambdageek
Customer Impact
Fixes application crashes on MacCatalyst in apps that use system frameworks such as SceneKit
Testing
Manual testing
Risk
Low. This reverts to the behavior before 5a1baeb for DllImports with an absolute path.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.