JIT: Move some BasicBlock methods into block.cpp #85224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect up a few `BasicBlock` methods that were scattered about in other files.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCollect up a few
|
Member
Author
|
@BruceForstall PTAL |
jakobbotsch
approved these changes
Apr 23, 2023
BruceForstall
approved these changes
Apr 24, 2023
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM. Looks like formatting needs to be fixed. Apparently you hit some kind of Azure Storage glitch with replay/asmdiffs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect up a few
BasicBlockmethods that were scattered about in other files.