[mono] refactor metadata update code #85177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow generic type definitions to can contain added members
Instead of using a for-loop, use an interator that will also pick up added methods from hot reload. There's an issue here compared to the old code: the old code could cope with MonoClass:methods containing null pointers. But the iterator approach signals that iteration is finished by returning NULL. Need to check whether the old code is reachable on modern .NET
This function shouldn't expect to see generic instances
fanyang-mono
requested review from
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
lambdageek
approved these changes
Apr 21, 2023
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
lgtm. but needs a few minor fixes
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 22, 2023
Member
|
All failures are known. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.