-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(76268): Fix invalid behavior for ignored properties with "new" mo… #84756
fix(76268): Fix invalid behavior for ignored properties with "new" mo… #84756
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsSimple change Dictionary<TKey,TValue>.Add(TKey, TValue) for adding new ignored property to Dictionary<TKey,TValue>.Item[TKey] Fixes #76268
|
@jeffhandley , can you review current PR quickly? I think, #66900 linked with the same lines and I want to fix it separately. |
@Maximys could you take a look at the test failures? My guess is that the change makes source generation fail in some way e.g. not producing source good to implement the abstract members. |
@layomia , ok, I'll try to look at the test failures a bit late. |
98033bb
to
42387a7
Compare
@layomia , I had just fixed failed tests by amend. Could you review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…difier of derived class.
42387a7
to
5f6670a
Compare
Simple change Dictionary<TKey,TValue>.Add(TKey, TValue) for adding new ignored property to Dictionary<TKey,TValue>.Item[TKey]
Fixes #76268