-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete gtGetStructHandle
and friends
#84212
Merged
AndyAyersMS
merged 11 commits into
dotnet:main
from
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
46eb1f6
Delete gtGetStructHandle[IfPresent]
SingleAccretion 0a91d91
Delete the canonical handle logic
SingleAccretion ef0795b
Delete handle handling from fgMakeMultiUse
SingleAccretion f59480b
Delete gtGetStructHandleForSIMD and friends
SingleAccretion e629e10
Delete now-unused SIMD cache entries
SingleAccretion 8772e61
Fix SIMD
SingleAccretion 63172e2
Fix fgMakeMultiUse
SingleAccretion c47f0fd
Delete the IsSimdAsHWIntrinsic logic
SingleAccretion 77e4dde
Merge branch 'main' of https://github.com/dotnet/runtime into No-Get-…
SingleAccretion 7249352
Merge branch 'main' of https://github.com/dotnet/runtime into No-Get-…
SingleAccretion b0374b7
Fix formatting
SingleAccretion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than
f(__Canon)
, which affects VN-based copy propagation.The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.