Enable more general BITCAST folding in local morph #84144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctness fixes: 1) The hacky way which contained indirections were handled will not work for targets where address containment has special rules that depends on the type being loaded. 2) Small-typed sources were not handled correctly. 3) Interference checks. This has some regressions attached to it because we now contain locals with optimizations disabled and that can lead to using double stores instead of integer ones when the user is a store itself.
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAnd fix a few issues with the support already present in lowering, in particular, start containing things under user-produced Regressions:
Fixes #71839.
|
|
Optional: add constant folding for GT_BITCAST in importer (gtFoldConstExpr) |
I'll let that wait until the support for double<->long bitcasts on 32 bit is added as otherwise importer code is not simplifiable. @dotnet/jit-contrib |
|
@SingleAccretion can you resolve conflicts -- sorry it took us so long to look at this one. |
jakobbotsch
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix a few issues with the support already present in lowering, in particular, start containing things under user-produced
BITCASTs.Regressions:
Fixes #71839.