-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Fix function pointer as fields inspection #83981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function pointer as fields inspection #83981
Conversation
This was missed when C# function pointers support was added to the runtime.
Tagging subscribers to this area: @tommcdon Issue DetailsThis was missed when C# function pointers support /cc @dotnet/dotnet-diag
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable and consistent with what I can see the rest of the debugger treating it like.
Where are the other places that the debugger treats function pointers like IntPtr? I see a lot of places where it is treating function pointers properly: |
For fields, this is called out as "all pointers are runtime/src/coreclr/debug/daccess/dacdbiimpl.cpp Lines 7223 to 7230 in e0e54f6
|
Where is the IntPtr set for all pointer types? The path modified in this PR is returning proper type handle for regular pointer types. |
I'm not sure. I tried removing the DAC guards and the codepath can work but does occasionally go through the |
This was missed when C# function pointers support
was added to the runtime. The current fix is reporting
all functions pointers as
IntPtr
type. It should bepossible in a future update to properly share the accurate
type of the function pointer.
/cc @dotnet/dotnet-diag