Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Proposal]: Add overload for EventSource primitives #83751

Merged
merged 15 commits into from
Jun 14, 2023
Merged

[API Proposal]: Add overload for EventSource primitives #83751

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
058a46b
Add overload for EventSource primitives
agocke Mar 21, 2023
dc1fef0
Remove unused suppressions in MetricsEventSource
agocke Mar 22, 2023
6ad50d9
Add doc comments for EventSourcePrimitive
agocke Mar 22, 2023
6b0def3
Remove suppressions from TransactionsEtwProvider
agocke Mar 22, 2023
1a5101c
Remove guidance around warning suppression, as the safe primitives sh…
agocke Mar 24, 2023
b9d9e26
Add tests
agocke Mar 30, 2023
2d79faa
API compat suppressions
agocke Mar 30, 2023
9d0e720
Add suppression for Mono
agocke Mar 30, 2023
9457427
Add remaining overloads as described in API review
agocke Apr 27, 2023
e901cb1
Merge remote-tracking branch 'upstream/main' into eventsource-overload
agocke May 19, 2023
a46ea12
Suppress warnings on TFMs < 8.0
agocke May 19, 2023
004cc81
Add suppressions for System.Thread.Tasks.Dataflow
agocke May 19, 2023
561ca35
Remove suppressions
agocke May 19, 2023
cf6b458
Merge remote-tracking branch 'upstream/main' into eventsource-overload
agocke Jun 9, 2023
da088aa
Merge remote-tracking branch 'upstream/main' into eventsource-overload
agocke Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into eventsource-overload
  • Loading branch information
@agocke
agocke committed Jun 9, 2023
commit cf6b458d109b2fc202674affd7576b4620a419ff
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Net/Security/NetEventSource.Security.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void AcceptSecurityContext(SafeFreeCredentials? credential, SafeDeleteCon
private void AcceptSecurityContext(string credential, string context, Interop.SspiCli.ContextFlags inFlags) =>
WriteEvent(AcceptSecuritContextId, credential, context, (int)inFlags);

[Event(OperationReturnedSomethingId, Keywords = Keywords.Default, Level = EventLevel.Informational)]
[Event(OperationReturnedSomethingId, Keywords = Keywords.Default, Level = EventLevel.Informational, Message = "{0} returned {1}.")]
public void OperationReturnedSomething(string operation, Interop.SECURITY_STATUS errorCode) =>
WriteEvent(OperationReturnedSomethingId, operation, errorCode);

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.