Skip to content

Conversation

@TIHan
Copy link
Contributor

@TIHan TIHan commented Mar 19, 2023

Resolves #83653

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 19, 2023
@ghost ghost assigned TIHan Mar 19, 2023
@ghost
Copy link

ghost commented Mar 19, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #83653

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Mar 20, 2023

@dotnet/jit-contrib @EgorBo This is ready - quick fix, no diffs

@@ -0,0 +1,28 @@
// Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we usually put such regressions to JitBlue folder (historical reasons) and name them like Github_XXX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. Next time, I'll put them there. Just got so used to putting them in here.

@TIHan TIHan merged commit eacb2f3 into dotnet:main Mar 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: Missing unsigned check for recent x < 0 optimization

2 participants