Re-order some blocks in runtimelookup #83453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsMotivation: #83430 (comment)
|
jakobbotsch
reviewed
Mar 15, 2023
Comment on lines
-415
to
-458
| if (result == PhaseStatus::MODIFIED_EVERYTHING) | ||
| { | ||
| if (opts.OptimizationEnabled()) | ||
| { | ||
| fgReorderBlocks(/* useProfileData */ false); | ||
| fgUpdateChangedFlowGraph(FlowGraphUpdates::COMPUTE_BASICS); | ||
| } | ||
| } |
There was a problem hiding this comment.
W.r.t. the confusing diffs, maybe try with this change reverted?
src/coreclr/jit/runtimelookup.cpp
Outdated
| nullcheckBb->bbJumpDest = fallbackBb; | ||
| fastPathBb->bbJumpDest = block; | ||
| nullcheckBb->bbJumpDest = fastPathBb; | ||
| fallbackBb->bbJumpDest = block; |
There was a problem hiding this comment.
What if you mark fallBackBb->bbSetRunRarely()? I had to do similar thing to re-arrange in #80297.
There was a problem hiding this comment.
G_M10050_IG01:
sub rsp, 40
;; size=4 bbWeight=1 PerfScore 0.25
G_M10050_IG02:
mov rcx, qword ptr GS:[0x0058]
mov rcx, qword ptr [rcx+30H]
mov edx, dword ptr [rcx+48H]
cmp edx, 2
jl SHORT G_M10050_IG04
;; size=21 bbWeight=1 PerfScore 6.25
G_M10050_IG03:
mov rcx, qword ptr [rcx+50H]
cmp qword ptr [rcx+10H], 0
jne SHORT G_M10050_IG05
;; size=11 bbWeight=0.90 PerfScore 5.42
G_M10050_IG04:
mov rcx, 0xD1FFAB1E
mov edx, 29
mov r8d, 2
call CORINFO_HELP_GETSHARED_NONGCTHREADSTATIC_BASE_NOCTOR_OPTIMIZED
mov qword ptr [rsp+20H], rax
;; size=31 bbWeight=0.09 PerfScore 0.25
G_M10050_IG05:
mov rax, qword ptr [rsp+20H]
mov eax, dword ptr [rax+8CH]
;; size=11 bbWeight=1 PerfScore 3.00
G_M10050_IG06:
add rsp, 40
ret
;; size=5 bbWeight=1 PerfScore 1.25vs.
G_M10050_IG01:
sub rsp, 40
;; size=4 bbWeight=1 PerfScore 0.25
G_M10050_IG02:
mov rax, qword ptr GS:[0x0058]
mov rax, qword ptr [rax+30H]
mov ecx, dword ptr [rax+48H]
cmp ecx, 2
jl SHORT G_M10050_IG06
;; size=21 bbWeight=1 PerfScore 6.25
G_M10050_IG03:
mov rax, qword ptr [rax+50H]
cmp qword ptr [rax+10H], 0
je SHORT G_M10050_IG06
;; size=11 bbWeight=0.90 PerfScore 5.42
G_M10050_IG04:
mov r9, qword ptr [rsp+20H]
mov eax, dword ptr [r9+8CH]
;; size=12 bbWeight=1 PerfScore 3.00
G_M10050_IG05:
add rsp, 40
ret
;; size=5 bbWeight=1 PerfScore 1.25
G_M10050_IG06:
mov rcx, 0xD1FFAB1E
mov edx, 29
mov r8d, 2
call CORINFO_HELP_GETSHARED_NONGCTHREADSTATIC_BASE_NOCTOR_OPTIMIZED
mov r9, rax
mov qword ptr [rsp+20H], r9
jmp SHORT G_M10050_IG04
;; size=36 bbWeight=0 PerfScore 0.00
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #83430 (comment) let's see the diffs. #83430 changes JIT-EE guid so can't see diffs there