Skip to content

[browser] cleanup before memory snapshot #83082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2023
Merged

[browser] cleanup before memory snapshot #83082

merged 3 commits into from
Mar 8, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 7, 2023 •
edited
Loading

Split from #82049

  • moved get_preferred_icu_asset
  • moved TZ detection
  • moved runtimeHelpers.waitForDebugger
  • replaced anyModule with EmscriptenModuleInternal type
  • added runtimeHelpers.updateGlobalBufferAndViews
  • removed obsolete comments about blazor startup sequence
  • removed duplicate calls mono_wasm_init_diagnostics (also previously blazor startup path)

@pavelsavara
- moved get_preferred_icu_asset
64eb318 
- moved TZ detection
- moved runtimeHelpers.waitForDebugger
- anyModule refactoring
- added runtimeHelpers.updateGlobalBufferAndViews
- removed obsolete comments about blazor startup sequence
- removed diplicate calls mono_wasm_init_diagnostics (also previously blazor startup path)
@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 7, 2023
@pavelsavara pavelsavara requested review from maraf and ilonatommy March 7, 2023 11:52
@pavelsavara pavelsavara self-assigned this Mar 7, 2023
@ghost
Copy link

ghost commented Mar 7, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Split from #82049

  • moved get_preferred_icu_asset
  • moved TZ detection
  • moved runtimeHelpers.waitForDebugger
  • anyModule refactoring
  • added runtimeHelpers.updateGlobalBufferAndViews
  • removed obsolete comments about blazor startup sequence
  • removed diplicate calls mono_wasm_init_diagnostics (also previously blazor startup path)
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara mentioned this pull request Mar 7, 2023
Merged
@pavelsavara pavelsavara marked this pull request as ready for review March 7, 2023 12:08
@pavelsavara pavelsavara requested review from lewing and kg as code owners March 7, 2023 12:08
kg
kg reviewed Mar 7, 2023
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Mar 7, 2023
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

lambdageek
lambdageek approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

threads and diagnostics looks ok

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

CI failure undefined symbol: mono_wasm_pthread_on_pthread_attached is fixed here #82826
CI failure System.IO.IOException: 'NuGet-Migrations' is #80619

@pavelsavara pavelsavara merged commit faa1d09 into dotnet:main Mar 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
@pavelsavara pavelsavara deleted the browser_cleanup1 branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg left review comments

@lambdageek lambdageek lambdageek approved these changes

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelsavara @kg @lambdageek @maraf @ilonatommy