Skip to content

Pass wasi invariant mode through env variable #82707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2023
Merged

Pass wasi invariant mode through env variable #82707

merged 4 commits into from
Mar 2, 2023

Conversation

mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Feb 27, 2023 •
edited
Loading

Fixes #82567

@ghost ghost assigned mkhamoyan Feb 27, 2023
@lewing lewing added the arch-wasm WebAssembly architecture label Feb 27, 2023
@ghost
Copy link

ghost commented Feb 27, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

arch-wasm
Milestone: -

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara reviewed Feb 27, 2023
View reviewed changes
ilonatommy
ilonatommy reviewed Feb 27, 2023
View reviewed changes
@radical
Copy link
Member

radical commented Feb 28, 2023

Also, add Invariant.Tests to https://github.com/dotnet/runtime/blob/main/src/libraries/tests.proj#L538-L547 so that gets run, and the change here gets tested.

This was referenced Feb 28, 2023
Closed
Closed
@ilonatommy
Copy link
Member

Failures in Build Libraries Test Run release mono_interpreter linux x64 Debug not connected, e.g. 189037 has them as well.

This was referenced Mar 1, 2023
Closed
Open
Closed
@mkhamoyan mkhamoyan marked this pull request as ready for review March 2, 2023 12:08
@mkhamoyan mkhamoyan requested a review from marek-safar as a code owner March 2, 2023 12:08
@mkhamoyan mkhamoyan merged commit 0d16da9 into dotnet:main Mar 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@radical radical Awaiting requested review from radical

@steveisok steveisok Awaiting requested review from steveisok

@marek-safar marek-safar Awaiting requested review from marek-safar

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@mkhamoyan mkhamoyan

Labels
arch-wasm WebAssembly architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasi] Invariant.Tests failing with Failed to load ./icudt.dat
5 participants
@mkhamoyan @radical @ilonatommy @pavelsavara @lewing