Skip to content

[release/7.0] Console.Unix: fix escape sequence for setting title on 'screen' TERM. #82432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 21, 2023

Backport of #82340 to release/7.0

Customer Impact

Powershell 7.3 users (.NET 7) experience freeze on Unix when using screen* Terminals. It's caused by the fact that so far we were using an incomplete escape sequence for setting Terminal title. The PR fixes the escape sequence value. More details can be found at #82110 (comment).

It's possible to reproduce the issue outside of PowerShell with:

Console.Title = "title";
Console.GetCursorPosition();

Testing

@tmds has provided the fix and tested the changes.

Risk

I can't think of any as of now.

No OOB changes needed for System.Console.

@adamsitnik adamsitnik added Servicing-consider Issue for next servicing release review area-System.Console labels Feb 21, 2023
@ghost
Copy link

ghost commented Feb 21, 2023

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #82340 to release/7.0

Customer Impact

Powershell 7.3 users (.NET 7) experience freeze on Unix when using screen* Terminals. It's caused by the fact that so far we were using an incomplete escape sequence for setting Terminal title. The PR fixes the escape sequence value. More details can be found at #82110 (comment).

It's possible to reproduce the issue outside of PowerShell with:

Console.Title = "title";
Console.GetCursorPosition();

Testing

@tmds has provided the fix and tested the changes.

Risk

I can't think of any as of now.

No OOB changes needed for System.Console.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Console

Milestone: -

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 21, 2023
@leecow leecow added this to the 7.0.5 milestone Feb 21, 2023
@carlossanlop
Copy link
Contributor

Seeing some weird failure related to servicing versions:

src/native/corehost/corehost.proj(92,5): error MSB3073:
(NETCORE_ENGINEERING_TELEMETRY=Build)
The command ""/Users/runner/work/1/s/src/native/corehost/build.sh" Debug x64
 -apphostver "7.0.4" -hostver "7.0.4" -fxrver "7.0.4" -policyver "7.0.4"
 -commithash "80a6889b30dd0df92f71cb9c9beeb4bf5703c44b" -os OSX -cmakeargs
 "-DVERSION_FILE_PATH=/Users/runner/work/1/s/artifacts/obj/_version.c"
 -runtimeflavor coreclr -outputrid osx-x64" exited with code 1.

Rebasing since I already merged the branding PR and a few dependency flow PRs. Let's see if that makes the error goes away.

@carlossanlop
Copy link
Contributor

New failures unrelated.

@carlossanlop carlossanlop merged commit 0e0edcd into release/7.0 Mar 9, 2023
@carlossanlop carlossanlop deleted the backport/pr-82340-to-release/7.0 branch March 9, 2023 01:25
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Console Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants