Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill missing @mention data in area-owners.json #82228

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

marek-safar
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: marek-safar
Assignees: -
Labels:

area-Meta

Milestone: -

@marek-safar marek-safar merged commit d43a9b2 into dotnet:main Feb 16, 2023
@marek-safar marek-safar deleted the fabricbot branch February 16, 2023 12:59
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2023
@jeffhandley
Copy link
Member

While doing some area owner maintenance, I noticed this PR had gotten merged last month. This change doesn't actually have any effect. (Sorry this data management is so messy.)

The area-owners.json file only drives https://issuesof.net and its queries for area owners, architectures, and operating systems. It doesn't drive mentions/notifications--that's controlled through fabricbot.json.

Was the intent of this change to get the included folks mentioned upon labeling of linkable-framework or size-reduction? If so, the only change that looks like is needed is to add @marek-safar to the mentions of linkable-framework in fabricbot.json.

https://github.com/dotnet/runtime/blob/eefaa5a/.github/fabricbot.json#L930-L939

I'm making a bunch of other updates to area-owners.md, area-owners.json, and fabricbot.config; I can add that change into what I'm doing now (and remove the superfluous data added into area-owners.json).

@akoeplinger
Copy link
Member

I'm making a bunch of other updates to area-owners.md, area-owners.json, and fabricbot.config; I can add that change into what I'm doing now (and remove the superfluous data added into area-owners.json).

Thanks, yes please do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants