Skip to content

Conversation

@omajid
Copy link
Member

@omajid omajid commented Feb 15, 2023

Backport of #82208 and #82185

@ghost ghost added area-Host community-contribution Indicates that the PR has been added by a community member labels Feb 15, 2023
@ghost
Copy link

ghost commented Feb 15, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: omajid
Assignees: -
Labels:

area-Host

Milestone: -

@carlossanlop carlossanlop requested review from rbhanda and wfurt March 8, 2023 05:32
@carlossanlop
Copy link
Contributor

@omajid this one also needs the Microsoft.NETCore.Platforms.csproj changes as explained in the 7.0 PR. Can you please add them?

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs OOB changes.

@wfurt do you mind reviewing this?

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 8, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 9, 2023
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the required OOB changes. Got offline confirmation from @wfurt that the changes look good.
Will merge after the CI is done (had to rebase).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop carlossanlop merged commit 6dcc744 into dotnet:release/6.0 Mar 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Host community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants