Skip to content

Conversation

tlakollo
Copy link
Contributor

@tlakollo tlakollo commented Feb 1, 2023

No description provided.

vitek-karas and others added 6 commits January 17, 2023 10:16
…ss on generic type (dotnet/linker#3186)

The warning needs to be generated from the origin where the field reference comes from - so if it's a method body, then from the method body. This is because the instantiation is determined by that place, not the field itself (the field is defined on an open generic definition of the type).

This syncs the relevants tests with a NativeAOT work-in-progress change, but in generately it adds a lot more cases and some better comments.

Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>

Commit migrated from dotnet/linker@c790896
[main] Update dependencies from dotnet/arcade


 - Analyzer fix

 - Update to net8

 - Update import order

 - Add net8 handling

 - Analyzer fixes

 - Merge branch 'main' into darc-main-328ee272-9fb8-4717-bae0-5575b14d7744

 - More analyzer fixes

 - Port fix from runtime

 - Update failing test

 - verbose test

 - Fix formatting

 - Fix the task to look for net8.0 location.
Revert test changes.

 - Workaround a possible issue in the new SDK

Commit migrated from dotnet/linker@2bd23e1
* Match SDK versions of MSBuild framework

* Bump to match runtime versions

Commit migrated from dotnet/linker@053438e
…127.1 (dotnet/linker#3195)

[main] Update dependencies from dotnet/arcade


Commit migrated from dotnet/linker@c4b2869
@tlakollo tlakollo added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Feb 1, 2023
@tlakollo tlakollo added this to the 8.0.0 milestone Feb 1, 2023
@tlakollo tlakollo requested a review from agocke February 1, 2023 01:40
@tlakollo tlakollo self-assigned this Feb 1, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tlakollo
Assignees: tlakollo
Labels:

area-Tools-ILLink

Milestone: 8.0.0

@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tlakollo
Assignees: tlakollo
Labels:

linkable-framework, area-Tools-ILLink

Milestone: 8.0.0

@tlakollo
Copy link
Contributor Author

tlakollo commented Feb 1, 2023

@agocke this requires an admin to create a merge commit instead of squashing, could you merge it?

@marek-safar marek-safar merged commit 351d2bf into dotnet:main Feb 1, 2023
@tlakollo tlakollo deleted the SyncILLink branch February 1, 2023 19:58
@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants