Skip to content

Fix nullability on IDesignerSerializationProvider.GetSerializer #81203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix nullability on IDesignerSerializationProvider.GetSerializer #81203

merged 2 commits into from
Jan 31, 2023

Conversation

elachlan
Copy link
Contributor

Related to ongoing work to null annotate the winforms codebase.

The annotations for IDesignerSerializationProvider.GetSerializer() need to be updated to reflect nullability for params currentSerializer and objectType as these parameters should allow null.

dotnet/winforms#8353 (comment)

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.ComponentModel labels Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to ongoing work to null annotate the winforms codebase.

The annotations for IDesignerSerializationProvider.GetSerializer() need to be updated to reflect nullability for params currentSerializer and objectType as these parameters should allow null.

dotnet/winforms#8353 (comment)

Author: elachlan
Assignees: -
Labels:

area-System.ComponentModel, community-contribution
Milestone: -

@elachlan
Copy link
Contributor Author

CC: @lonitra @KlausLoeffelmann

@elachlan elachlan mentioned this pull request Jan 26, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Jan 26, 2023
Closed
@elachlan elachlan requested a review from stephentoub January 30, 2023 05:25
@stephentoub stephentoub merged commit 37b12da into dotnet:main Jan 31, 2023
@elachlan elachlan deleted the IDesignerSerializationProvider-nullability branch January 31, 2023 20:00
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.ComponentModel community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elachlan @stephentoub