Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve recently introduce ASCII regression #80709

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Solve recently introduce ASCII regression #80709

merged 3 commits into from
Jan 17, 2023

Commits on Jan 16, 2023

  1. call the helper method directly: 

    * one less method call
* one less pinning
* don't create a Span out of pointer just to fix it and get the pointer
    @adamsitnik
    adamsitnik committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5596b4c View commit details
    Browse the repository at this point in the history

  2. inline the helper that was supposed to be public into it's only caller

    @adamsitnik
    adamsitnik committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    030b731 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. call other helpers directly too, as most of them are on hot paths and… 

    … overhead matters for small inputs
    @adamsitnik
    adamsitnik committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    fc5d1e8 View commit details
    Browse the repository at this point in the history