-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[JIT] - X64 - Peephole optimization to possibly skip emitting and reg, -1
#80468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsA minor change, based off of #79630 The example: static uint Y(uint i)
{
return i & uint.MaxValue;
}
|
TIHan
commented
Jan 10, 2023
and reg, -1
Contributor
Author
|
@dotnet/jit-contrib this is ready, pending CI, - @BruceForstall PTAL |
Contributor
BruceForstall
approved these changes
Jan 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

A minor change, it is similar to the work here -> #79630
The example:
The emitted

and reg, -1can be skipped if we know that thereg's upper 32-bits are zero'ed and that the operation is 32-bits.Overall, there are not that many improvements, but improvements nonetheless.