-
Notifications
You must be signed in to change notification settings - Fork 5k
NativeAOT for FreeBSD #80323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeAOT for FreeBSD #80323
Conversation
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Test failure is unrelated(?). Side question: Will there be tags for the new SDK that is being used? the |
Yes, it is #78454 and #73721. You can mark your PR ready for review.
This gives us the commit info: $ cd runtime
$ ./dotnet.sh --info
.NET SDK:
Version: 8.0.100-alpha.1.23061.8
Commit: c8d103ed3c <---------- this is SDK commit
...
Host:
Version: 8.0.0-alpha.1.23058.2
Architecture: arm64
Commit: 5da4a9e919 <---------- this is Runtime commit
# extract commit in script
$ SDK_COMMIT="$(.dotnet/dotnet --info | grep -A3 'SDK:' | grep Commit | while IFS=\ read tag hash; do echo "$hash"; done)"
$ RUNTIME_COMMIT="$(.dotnet/dotnet --info | grep -A3 'Host:' | grep Commit | while IFS=\ read tag hash; do echo "$hash"; done)" |
…o.cs Co-authored-by: Robin Sue <robinsue@live.de>
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
src/installer/managed/Microsoft.NET.HostModel/Bundle/TargetInfo.cs
Outdated
Show resolved
Hide resolved
…o.cs Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Need to wait for dotnet/sdk#29800 to be merged first before merging this one. |
Thank you! |
* add inotify for FreeBSD during linking * remove FreeBSD for now * netstandard does not understand FreeBSD * add FreeBSD platform to HostModel Tests * add inotify for FreeBSD during linking * remove FreeBSD for now * netstandard does not understand FreeBSD * add FreeBSD platform to HostModel Tests * Use Clang12, update LinkerArg * WIP FreeBSD NativeAOT * add inotify for FreeBSD during linking * remove FreeBSD for now * netstandard does not understand FreeBSD * add FreeBSD platform to HostModel Tests * WIP FreeBSD NativeAOT * remove FreeBSD for now * add FreeBSD platform to HostModel Tests * Use Clang12, update LinkerArg * Update JITTools and ObjWriter for FreeBSD-x64 * fixes for tests * fixes for tests * add TargetTriple for FreeBSD * Some changes from feedback, remove out of scope * HostModel back to netstandard2.0 * Update src/coreclr/CMakeLists.txt * Publish crossgen2 as single-file on cross-os * pass NativeAotSupported to MSBuild crossgen2 tasks * Can't use NativeAOT in source build yet Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update private string HostFxr and HostPolicy * Fix private string HostPolicy * Apply suggestions from code review Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Robin Sue <robinsue@live.de>
Initial NativeAOT for FreeBSD work