Skip to content

Remove incorrect assert from UnixEvent::Wait #80270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 2 commits into from
Jan 6, 2023
Merged

Remove incorrect assert from UnixEvent::Wait #80270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5457595
Remove incorrect assert from UnixEvent::Wait
janvorli Jan 5, 2023
f246a00
Fix one more occurence of the same assert
janvorli Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/coreclr/gc/unix/events.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,6 @@ class GCEvent::Impl
#else // HAVE_CLOCK_GETTIME_NSEC_NP
st = pthread_cond_timedwait(&m_condition, &m_mutex, &endTime);
#endif // HAVE_CLOCK_GETTIME_NSEC_NP
// Verify that if the wait timed out, the event was not set
assert((st != ETIMEDOUT) || !m_state);
}

if (st != 0)
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,6 @@ class UnixEvent
#else // HAVE_CLOCK_GETTIME_NSEC_NP
st = pthread_cond_timedwait(&m_condition, &m_mutex, &endTime);
#endif // HAVE_CLOCK_GETTIME_NSEC_NP
// Verify that if the wait timed out, the event was not set
ASSERT((st != ETIMEDOUT) || !m_state);
}

if (st != 0)
Expand Down