delete tfm constants #79219
Merged
delete tfm constants #79219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Details@ViktorHofer i found some unused constants. i think it's easier to follow with strings for the rest
|
ViktorHofer
reviewed
Dec 5, 2022
devsko
reviewed
Dec 5, 2022
| var deploymentParameters = new DeploymentParameters( | ||
| applicationPath, | ||
| RuntimeFlavor.CoreClr, | ||
| RuntimeArchitecture.x64) | ||
| { | ||
| TargetFramework = Tfm.NetCoreApp50, | ||
| TargetFramework = $"Environment{version.Major}.{version.Minor}", |
There was a problem hiding this comment.
@kasperk81 Shouldn't this read $"net{version.Major}.{version.Minor}" (or null)?
There was a problem hiding this comment.
ooops, #79230. thanks for catching it
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ViktorHofer i found some unused constants. i think it's easier to follow with strings for the rest