Skip to content

[release/7.0] [wasm][debugger] Fix justMyCode behavior #78216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 11, 2022

Backport of #78066 to release/7.0

/cc @thaystg

Customer Impact

To make JustMyCode work the customer needs to enable and disable it after the app is already running.

Testing

Manually tested by me and Daniel Roth.

Risk

Low risk, only accepting messages related to JustMyCode even if the ExecutionContext is not created yet.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78066 to release/7.0

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg requested a review from lewing November 11, 2022 12:34
@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Nov 11, 2022
@thaystg thaystg added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 14, 2022
@thaystg
Copy link
Member

thaystg commented Nov 14, 2022

Approved by email.

@carlossanlop carlossanlop added this to the 7.0.1 milestone Nov 14, 2022
@carlossanlop
Copy link
Contributor

Approved by Tactics via email.
Signed off by area owner.
CI failures were staging timeout cancellations.
No OOB package authoring changes needed for this.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 86226c5 into release/7.0 Nov 14, 2022
@carlossanlop carlossanlop deleted the backport/pr-78066-to-release/7.0 branch November 14, 2022 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants