[release/6.0] Suppress warnings for deprecated keychain APIs #77926
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsBackport of #77911 to release/6.0 /cc @vcsjones Customer ImpactThis change fixes compiling with the latest Xcode tooling. In Xcode 14.1, Apple deprecated several APIs related to their Keychain APIs. This change suppresses the obsolete warnings so the build continues. The Mac Pools for CI will need this change for CI to continue to build when the Mac Pool eventually gets updated to this version of the tooling. TestingVerified compilation succeeds with Xcode 14.1 toolchain. RiskVery low. This makes no functional changes, and fixes a build-break using IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
This is a build-only change |
|
@vcsjones or @akoeplinger can you please send the email to Tactics to request merge approval? |
|
@bartonjs @akoeplinger I lack this capability / knowledge. |
|
These are just pragmas, so we can treat it as an infrastructure change and just make it "tell mode" to tactics. Let's just draft an email that let's them know we're merging this (and the 7.0 PR) in order to be able to continue building this component with the latest toolchain. |
|
Too late, I've already sent the tactics email a few minutes ago 😄 |
carlossanlop
added
Servicing-approved
|
Ok got it. Tell mode, so I'll add the label. Thank you Alexander for sending the email anyway. |
Backport of #77911 to release/6.0
/cc @vcsjones
Customer Impact
This change fixes compiling with the latest Xcode tooling.
In Xcode 14.1, Apple deprecated several APIs related to their Keychain APIs. This change suppresses the obsolete warnings so the build continues. The Mac Pools for CI will need this change for CI to continue to build when the Mac Pool eventually gets updated to this version of the tooling.
Testing
Verified compilation succeeds with Xcode 14.1 toolchain.
Risk
Very low. This makes no functional changes, and fixes a build-break using
#pragmadirectives to suppress the warning.IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.