Produce crashreport.json and use llvm-symbolizer to create stack trace by kunalspathak · Pull Request #77578 · dotnet/runtime

kunalspathak · 2022-10-28T00:53:44Z

Contributes to #75243 and #77918

ghost · 2022-10-28T00:54:04Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	kunalspathak
Assignees:	-
Labels:	`NO-MERGE`, `NO-REVIEW`, `area-CodeGen-coreclr`
Milestone:	-

This reverts commit 4e85471.

…access

ghost · 2022-12-06T17:53:22Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #75243 and #77918

Author:	kunalspathak
Assignees:	kunalspathak
Labels:	`area-Infrastructure-coreclr`
Milestone:	-

kunalspathak · 2022-12-08T20:04:23Z

Ping @hoyosjs

hoyosjs · 2022-12-08T20:07:03Z

Will try to take a look between today and tomorrow.

kunalspathak · 2022-12-13T21:50:48Z

Ping @hoyosjs

agocke · 2022-12-14T22:06:58Z

How will this work on systems like Alpine (musl) where we don't have dotnet installed on the machine, and the .NET runtime being tested is presumably broken?

kunalspathak · 2022-12-14T22:55:55Z

It won't. This is just for Ubuntu x64 (for now).

agocke

I'd consider writing some unit tests for this. There;s no reason why we can't manually create a crashing process and ensure this works.

kunalspathak · 2022-12-15T03:06:15Z

I'd consider writing some unit tests for this.

I am not sure if we have an infrastructure/existing test cases to test any of this code. @hoyosjs do we?

agocke · 2022-12-15T03:37:16Z

If we don't have infrastructure for testing this I think we need to make it. This code is supposed to be robust exactly in the edge cases where we won't get a lot of coverage. Testing a few simple cases and in PRs won't cut it.

kunalspathak · 2022-12-15T03:51:19Z

If we don't have infrastructure for testing this I think we need to make it.

I agree, but I don't have bandwidth to do it this week. If we want, we can have this PR open until January when I can start looking at how to test it.

agocke · 2022-12-15T05:32:16Z

Sounds good, I don't think there's a rush to get this in this year. I'd rather do it right

agocke

LGTM

Let's follow-up with unit tests when we have time to schedule it

agocke · 2023-01-26T22:53:25Z

+                string userName = Environment.GetEnvironmentVariable("USER");
+                if (!string.IsNullOrEmpty(userName))
+                {
+                    if (!RunProcess("sudo", $"chown {userName} {crashReportJsonFile}"))


If elevating works on Mac right now, that's great, but I could see this not working forever, so we should give a little thought to what we would do instead.

…ack trace (#77578)" This reverts commit ff987dc.

…ack trace (dotnet#77578)" This reverts commit ff987dc.

…ack trace (#77578)" (#81379) This reverts commit ff987dc.

…reate stack trace (dotnet#77578)" (dotnet#81379)" This reverts commit 3c76e14.

* Revert "Revert "Produce crashreport.json and use llvm-symbolizer to create stack trace (#77578)" (#81379)" This reverts commit 3c76e14. * Add nativeSymbols only for PRs

kunalspathak added 2 commits October 27, 2022 17:39

add DOTNET_EnableCrashReport

ae22daa

Enable JitStress and JitStressRegs by default to see some test failures

770b4c5

kunalspathak added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Oct 28, 2022

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 28, 2022

ghost assigned kunalspathak Oct 28, 2022

Enable stress switches only for JIT

b98f363

kunalspathak force-pushed the merge-on-red branch from fc107fd to b98f363 Compare October 28, 2022 21:44

kunalspathak added 2 commits October 28, 2022 17:13

fix the build errors

7f444a7

Revert "Set DNER for all local fields (dotnet#77341)"

5cfff11

This reverts commit 4e85471.

This was referenced Oct 31, 2022

Infra improvements for Helix #68176

Closed

Long Running Test: Interop/MonoAPI/MonoMono/PInvokeDetach/PInvokeDetach.sh #73040

Closed

kunalspathak added 8 commits October 31, 2022 16:15

Set EnableCrashReport in testenvironment.proj

2988f89

Pass --crashReport to capture for hangs

bccea52

Comment bunch of jobs to trigger

e804a12

Comment all runs except Linux_x64

b093dcb

Stop running libraries job

f1caaaf

Fix the tag in testenvironment.proj

c39de18

Use keepnativesymbols

f79abc2

Update JitStress/JitStressRegs

8bc94d5

kunalspathak mentioned this pull request Nov 4, 2022

[Merge-on-Red] - Generate native/manage stack traces for runtime test crashes #77918

Closed

3 tasks

kunalspathak added 8 commits November 11, 2022 01:00

Embed native_image_offset field in crashreport.json

28a38b9

Add TryPrintStackTraceFromCrashReport()

70545f6

Call TryPrintStackTraceFromCrashReport() even for crashes

f0b5df6

Add newtonsoft in CoreCLRTestLibrary.csproj

b4f5037

Fix the crash dump folder

4504340

Add random failure in jit

940c300

Add some logging around TryPrintStackTraceFromCrashReport

e40b789

Move the error randomization to GetLayout() that has compiler object …

230d239

…access

agocke reviewed Dec 14, 2022

View reviewed changes

Address review feedback

63a07b7

agocke reviewed Dec 15, 2022

View reviewed changes

Comment thread src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs

build-analysis Bot mentioned this pull request Dec 15, 2022

Build fails with "eng/common/tools.sh: line 474: 537 Segmentation fault" #76759

Closed

agocke approved these changes Jan 26, 2023

View reviewed changes

kunalspathak merged commit ff987dc into dotnet:main Jan 27, 2023

kunalspathak deleted the merge-on-red branch January 27, 2023 07:44

eerhardt mentioned this pull request Jan 30, 2023

Publish size regression on Linux #81374

Closed

agocke added a commit that referenced this pull request Jan 30, 2023

Revert "Produce crashreport.json and use llvm-symbolizer to create st…

6b6659a

…ack trace (#77578)" This reverts commit ff987dc.

kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Jan 30, 2023

Revert "Produce crashreport.json and use llvm-symbolizer to create st…

7e0d01d

…ack trace (dotnet#77578)" This reverts commit ff987dc.

kunalspathak mentioned this pull request Jan 30, 2023

Revert "Produce crashreport.json and use llvm-symbolizer to create st… #81379

Merged

kunalspathak added a commit that referenced this pull request Jan 30, 2023

Revert "Produce crashreport.json and use llvm-symbolizer to create st…

3c76e14

…ack trace (#77578)" (#81379) This reverts commit ff987dc.

kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Jan 30, 2023

Revert "Revert "Produce crashreport.json and use llvm-symbolizer to c…

bada32b

…reate stack trace (dotnet#77578)" (dotnet#81379)" This reverts commit 3c76e14.

ghost locked as resolved and limited conversation to collaborators Feb 26, 2023

Uh oh!

Conversation

kunalspathak commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 28, 2022

Uh oh!

ghost commented Dec 6, 2022

Uh oh!

kunalspathak commented Dec 8, 2022

Uh oh!

hoyosjs commented Dec 8, 2022

Uh oh!

kunalspathak commented Dec 13, 2022

Uh oh!

agocke commented Dec 14, 2022

Uh oh!

kunalspathak commented Dec 14, 2022

Uh oh!

agocke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kunalspathak commented Dec 15, 2022

Uh oh!

Uh oh!

agocke commented Dec 15, 2022

Uh oh!

kunalspathak commented Dec 15, 2022

Uh oh!

agocke commented Dec 15, 2022

Uh oh!

agocke left a comment

Choose a reason for hiding this comment

Uh oh!

agocke Jan 26, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kunalspathak commented Oct 28, 2022 •

edited

Loading