[mono][sgen] Fix detection of weakref objects #77170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparison with klass mono_defaults.generic_weakreference_class was broken because that class is a generic class while the objects have as a class generic instantiations of that so the comparison would fail. Simplify the code by adding a new gc bit where we can use name comparison.
BrzVlad
requested review from
lambdageek,
naricc,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @BrzVlad Issue DetailsComparison with mono_defaults.generic_weakreference_class was broken because that class is a generic class while the objects have as a class generic instantiations of that, so the comparison would fail. Simplify the code by adding a new gc bit where we can use name comparison.
|
filipnavara
approved these changes
Oct 18, 2022
vargaz
approved these changes
Oct 19, 2022
Member
|
Does this fix |
Member
Author
yes |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison with mono_defaults.generic_weakreference_class was broken because that class is a generic class while the objects have as a class generic instantiations of that, so the comparison would fail. Simplify the code by adding a new gc bit where we can use name comparison.
Fixes bug from #76173