Skip to content

Make sure that CoreLib ref and src build matches #77116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make sure that CoreLib ref and src build matches #77116

wants to merge 1 commit into from

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Oct 17, 2022

Fixes #75897

This change fixes src/CoreLib referencing ref/CoreLib with a different set of global properties. When building the runtime and libraries in Release mode, the build (at least inside VS) complains that the ref/CoreLib assembly (in Debug configuration) is missing.

Undefined behavior: When src/CoreLib is built in Checked configuration, should ref/CoreLib then also be built in Checked mode?

@ViktorHofer
Make sure that CoreLib ref and src build matches
3ae7933 
This change fixes src/CoreLib referencing ref/CoreLib with a different
set of global properties. When building the runtime and libraries in
Release mode, the build (at least inside VS) complains that the
ref/CoreLib assembly (in Debug configuration) is missing.
@ghost ghost assigned ViktorHofer Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75897

This change fixes src/CoreLib referencing ref/CoreLib with a different set of global properties. When building the runtime and libraries in Release mode, the build (at least inside VS) complains that the ref/CoreLib assembly (in Debug configuration) is missing.

Undefined behavior: When src/CoreLib is built in Checked configuration, should ref/CoreLib then also be built in Checked mode?

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ViktorHofer ViktorHofer requested a review from ericstj October 17, 2022 14:52
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 17, 2022

I'm not 100% sure if src/CoreLib should govern ref/CoreLib's build configuration. It could also be the case that the initial described issue happened because ref/CoreLib was missing from solution files.

@build-analysis build-analysis bot mentioned this pull request Oct 17, 2022
Closed
@ViktorHofer ViktorHofer deleted the MakeCoreLibRefAndSrcConfigurationsConsistent branch October 19, 2022 16:57
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@ericstj ericstj Awaiting requested review from ericstj

Assignees

@ViktorHofer ViktorHofer

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release-only build has errors due to ResolvedMatchingContract when re-compiling in Visual Studio

1 participant

@ViktorHofer