Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DiagnosticSource to work with NativeAOT #76109

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Fix DiagnosticSource to work with NativeAOT #76109

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1227d64
Fix DiagnosticSource to work with NativeAOT
eerhardt Sep 23, 2022
ba624bf
Enable new NativeAotTests in CI
eerhardt Sep 26, 2022
b633e7f
Fix NativeAOT tests
eerhardt Sep 27, 2022
3b4f5bd
Fix test CI leg
eerhardt Sep 27, 2022
ccca518
Set IlcFrameworkNativePath correctly
eerhardt Sep 27, 2022
9aeca47
Don't run NativeAot published app tests on OSX since it isn't supported
eerhardt Sep 27, 2022
15824c8
Respond to PR feedback
eerhardt Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't run NativeAot published app tests on OSX since it isn't supported
  • Loading branch information
@eerhardt
eerhardt committed Sep 27, 2022
commit 9aeca478217d82db6d7636e2839519ae89d99741
3 changes: 2 additions & 1 deletion eng/pipelines/coreclr/nativeaot-post-build-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ steps:
displayName: Run tests in single file mode

# Publishing tooling doesn't support different configs between runtime and libs, so only run tests in Release config
- ${{ if eq(parameters.buildConfig, 'release') }}:
# PublishAot on OSX doesn't work yet. Need an SDK with https://github.com/dotnet/installer/pull/14443.
- ${{ if and(eq(parameters.buildConfig, 'release'), ne(parameters.osGroup, 'OSX')) }}:
- script: $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci -arch ${{ parameters.archType }} $(_osParameter) -s libs.tests -c $(_BuildConfig) /p:TestAssemblies=false /p:RunNativeAotTestApps=true $(_officialBuildParameter) $(_crossBuildPropertyArg) /bl:$(Build.SourcesDirectory)/artifacts/log/$(buildConfigUpper)/NativeAotTests.binlog ${{ parameters.extraTestArgs }}
displayName: Run NativeAot Library Tests