Skip to content

[release/7.0] [NativeAOT] Ensure that frozen objects respect the minimum object size #76050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 23, 2022

Backport of #76031 to release/7.0

/cc @jkotas @filipnavara

Customer Impact

Intermittent crash during GC in native AOT apps

The crash is triggered by a specific virtual address space layout (one GC segment mapped before native binary and second GC segment mapped after the native compiled binary).

Testing

Default native aot CI run

Risk

Low, the change is specific to native aot compiler.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@jkotas jkotas added the Servicing-consider Issue for next servicing release review label Sep 23, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in ga.

@carlossanlop
Copy link
Contributor

@jkotas or @jeffschwMSFT can you send the email to Tactics, please?

@jkotas
Copy link
Member

jkotas commented Sep 26, 2022

@jkotas or @jeffschwMSFT can you send the email to Tactics, please?

Done.

@carlossanlop carlossanlop added api-approved API was approved in API review, it can be implemented Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review api-approved API was approved in API review, it can be implemented labels Sep 26, 2022
@carlossanlop
Copy link
Contributor

Approved by Tactics via email.

@carlossanlop carlossanlop added this to the 7.0.0 milestone Sep 26, 2022
@carlossanlop carlossanlop merged commit 8419a11 into release/7.0 Sep 26, 2022
@carlossanlop carlossanlop deleted the backport/pr-76031-to-release/7.0 branch September 26, 2022 21:12
@ghost ghost locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants