[wasm][debugger] Support create, debugging and running wasmbrowser template from VS #75986
Conversation
thaystg
requested review from
lewing,
pavelsavara and
radical
as code owners
|
Tagging subscribers to this area: @thaystg Issue DetailsScreenRecorderProject1.mp4
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsScreenRecorderProject1.mp4
|
| "environmentVariables": { | ||
| "ASPNETCORE_ENVIRONMENT": "Development" | ||
| }, | ||
| "applicationUrl": "https://localhost:5001;http://localhost:5000", |
There was a problem hiding this comment.
can we use https_port, and http_port here instead of the actual numbers?
There was a problem hiding this comment.
These numbers will be replaced by a generated number as is done on blazor apps, they are not fixed. And also, after it's generated the user can change in this applicationUrl and we will respect it.
A generated file with the ports replaced:
| "type": "generated", | ||
| "generator": "port", | ||
| "parameters": { | ||
| "low": 7000, |
There was a problem hiding this comment.
Maybe not relevant for this PR, but I noticed that the HTTPS didn't have a cert which my browser would trust. On the other hand any ASP.NET project has some dev cert installed. Could we also use it ?
src/mono/wasm/host/BrowserHost.cs
Outdated
| debugging: _args.CommonConfig.Debugging); | ||
| runArgsJson.Save(Path.Combine(_args.CommonConfig.AppPath, "runArgs.json")); | ||
|
|
||
| var urls = new string[] { $"http://127.0.0.1:{_args.CommonConfig.HostProperties.WebServerPort}", "https://127.0.0.1:0" }; |
There was a problem hiding this comment.
can we use localhost here instead?
|
Curious to know, might this make it to RC2? Very keen to try this out😎 |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3116836063 |
It will be in 7.0 but it missed rc2 |
ghost
locked as resolved and limited conversation to collaborators
5 participants
ScreenRecorderProject1.mp4