-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[release/7.0-rc2] [wasm] fix missing managed stack trace on managed exceptions marshaled to JS #75799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-rc2] [wasm] fix missing managed stack trace on managed exceptions marshaled to JS #75799
Conversation
* override `get stack` * fix Firefox tests
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #75678 to release/7.0-rc2 /cc @pavelsavara @kg Customer ImpactFixes stack trace on managed stack trace, which was marshaled as JavaScript Error. The main impact is that unhanded exceptions from [JSExport] will be easier to diagnose than without the managed stack. TestingI done:
RiskLow
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
The issue is |
Needs Tactics approval. @pavelsavara please send the email to Tactics if you haven't yet. |
The CI failures are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on approvals on the original PR for main
.
The wasm/runtimeTests failures are unrelated. |
And the failure to resolve Microsoft.Build.NoTargets/3.5.0 is this existing issue, which is a duplicate of this more generic one. Signed off, approved, ready to merge. |
Backport of #75678 to release/7.0-rc2
/cc @pavelsavara @kg
Customer Impact
Fixes stack trace on managed stack trace, which was marshaled as JavaScript Error. The main impact is that unhanded exceptions from
[JSExport]
will be easier to diagnose than without the managed stack.Testing
I done:
Risk
Low
There is probably no production code which would rely on this yet, as the
[JSExport]
interop is new in .Net 7.The stack traces are targeted at human developer and relying on exact text of the stack trace is considered bad practice.