[release/6.0] Fix build for musl 1.2.3 (backports #67772) #75529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
9 tasks
|
@janvorli can you help fill out the template? This needs to go through Tactics, so once it's ready, please add the |
VSadov
approved these changes
Sep 14, 2022
danmoseley
added
Servicing-approved
|
CI is green. Approved. Signed off. No OOB package authoring changes since this is native code. |
vseanreesermsft
pushed a commit
to vseanreesermsft/runtime
that referenced
this pull request
Oct 11, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #67772
Not a functional change.
This is to fix the build with musl 1.2.3 , which was released 7 Apr 2022
Most of the change is switching
NULL->nullptrin some PAL functions to match musl changes.Customer Impact
No impact, this is an infra/build level of a fix.
Risk
Low, it is a build-related change that should be transparent outside of dotnet/runtime.
Testing
Regular tests.