Skip to content

Change VerifyXmlResolver to use TcpListener over HttpListener #75369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2022
Merged

Change VerifyXmlResolver to use TcpListener over HttpListener #75369

merged 3 commits into from
Sep 20, 2022

Conversation

bartonjs
Copy link
Member

@bartonjs bartonjs commented Sep 9, 2022

Addresses #74115 in main.

@bartonjs bartonjs added area-System.Security test-enhancement Improvements of test source code labels Sep 9, 2022
@bartonjs bartonjs added this to the 8.0.0 milestone Sep 9, 2022
@bartonjs bartonjs self-assigned this Sep 9, 2022
@ghost
Copy link

ghost commented Sep 9, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses #74115 in main.

Author: bartonjs
Assignees: bartonjs
Labels:

area-System.Security, test-enhancement
Milestone: 8.0.0

wfurt
wfurt reviewed Sep 9, 2022
View reviewed changes
stephentoub
stephentoub reviewed Sep 12, 2022
View reviewed changes
wfurt
wfurt reviewed Sep 13, 2022
View reviewed changes
@jeffhandley jeffhandley linked an issue Sep 16, 2022 that may be closed by this pull request
SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost. #74115
Open
@bartonjs
Copy link
Member Author

Any other feedback, @wfurt?

wfurt
wfurt approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented Sep 20, 2022

sorry for late response @bartonjs. it slipped from my radar.

@bartonjs bartonjs merged commit 9e4829d into dotnet:main Sep 20, 2022
@bartonjs bartonjs deleted the VerifyXmlResolver_TcpListener branch September 20, 2022 22:21
@bartonjs
Copy link
Member Author

If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.

karelz added a commit that referenced this pull request Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16 
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelz karelz mentioned this pull request Sep 24, 2022
Merged
@karelz
Copy link
Member

karelz commented Sep 24, 2022

The failures are back -- I reopened #74115

karelz added a commit that referenced this pull request Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909 
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@wfurt wfurt wfurt approved these changes

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

Assignees

@bartonjs bartonjs

Labels
area-System.Security test-enhancement Improvements of test source code
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
4 participants
@bartonjs @wfurt @karelz @stephentoub