Skip to content

Update provider_compute_event_enable_mask so EventSouces with no keywords show up by default #75248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Update provider_compute_event_enable_mask so EventSouces with no keywords show up by default #75248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
febfd88
Update ep-provider.c
davmason Sep 8, 2022
480eee9
Code review feedback
davmason Sep 20, 2022
d0a91c5
Don't change -1 as a keyword
davmason Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/native/eventpipe/ep-provider.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,16 @@ ep_provider_add_event (

ep_requires_lock_not_held ();

// Keyword bits 44-47 are reserved for use by EventSources, and every EventSource sets them all.
// We filter out those bits here so later comparisons don't have to take them in to account. Without
// filtering, EventSources wouldn't show up with Keywords=0.
uint64_t session_mask = ~0xF00000000000;
// -1 is special, it means all keywords. Don't change it.
uint64_t all_keywords = (uint64_t)(-1);
if (keywords != all_keywords) {
keywords &= session_mask;
}

EventPipeEvent *instance = ep_event_alloc (
provider,
keywords,
Expand Down