Skip to content

Update public pool names #74907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

alexperovich
Copy link
Member

This change is required for builds to continue working in the new org, dev.azure.com/dnceng-public.

@ghost
Copy link

ghost commented Sep 1, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This change is required for builds to continue working in the new org, dev.azure.com/dnceng-public.

Author: alexperovich
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

This one can be closed in favor of #74906 which flows automatically into release/7.0.

@ViktorHofer ViktorHofer closed this Sep 1, 2022
@ViktorHofer ViktorHofer deleted the release/7.0-publicPoolNames branch September 1, 2022 12:20
@carlossanlop
Copy link
Contributor

This should've been merged. We aren't working on rc1 anymore. The release/7.0 branch is the one we are actively working on and is currently blocked until we merge the backport.

@ViktorHofer
Copy link
Member

Must disagree here. The same PR was already merged into release/7.0-rc1 and as we still have the maestro flow enabled, we don't need this one.

@carlossanlop
Copy link
Contributor

Right, but we already generated a coherent build out of RC1 so that branch is 'done'. Merging here, then waiting for the bot to flow it to release/7.0 was an unnecessary step, considering we are all now actively working in the release/7.0 branch.

@ViktorHofer
Copy link
Member

Consider someone noticing a highly impactful bug in the runtime that impacts RC1 during validation. We would need to fix that and re-spin the builds. I think it was right for @alexperovich to target release/7.0-rc1 to make sure that in the worst case, this branch continues to be buildable. And as that PR already targeted release/7.0-rc1, there was no need to also target release/7.0.

Basically what I'm saying is that these three PRs could have just been one (which is why I closed the other ones):

@carlossanlop
Copy link
Contributor

Hmm ok, fair enough.

What is the recommended way to restart the CI on the backports that didn't get the CI of the newest commits triggered due to the system being down? /azp run runtime? Closing and reopening? Something else?

@ViktorHofer
Copy link
Member

Closing and reopening probably otherwise you would need to azp run all pipelines that are enabled per PR.

@carlossanlop
Copy link
Contributor

Thanks. But one of those two does not rebase with the base branch, right? I think the correct case here is to use closing and reopening, since we need the PRs to consume the server name changes.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants