[mini] double quote linker path in defined(LD_NAME) case #74451
Conversation
In dotnet@e71a958 we started setting a default `LD_NAME` for x86 non-mach targets Fixes Android x86 builds that specify a `tool_prefix` with spaces in it
|
This is primarily to fix a regression for net7 XA. for net8 we should make an issue to clean up / simplify all this |
|
we need this in rc1 correct? |
yes |
| else if (acfg->aot_opts.llvm_only) | ||
| g_string_append_printf (str, "%s", acfg->aot_opts.clangxx); | ||
| else | ||
| g_string_append_printf (str, "\"%s%s\" %s", tool_prefix, ld_binary_name, LD_OPTIONS); |
There was a problem hiding this comment.
in the other version we're not adding LD_OPTIONS in the else case
There was a problem hiding this comment.
I'm trying to preserve the old behavior of the defined(LD_NAME) case - if a tool prefix option isn't set, it uses the ld_binary_name (ie LD_NAME by default) and LD_OPTIONS
There was a problem hiding this comment.
yeah but I'm more worried about the previous behavior of Android x86, we care more about that than Desktop Linux x86
There was a problem hiding this comment.
Android sets acfg->aot_opts.tool_prefix, so it's in the "cross compiling" branch, below, not the final "else" branch. So it adds LD_OPTIONS
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
In
e71a958
we started setting a default
LD_NAMEfor x86 non-mach targetsFixes Android x86 builds that specify a
tool_prefixwith spaces in itFixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1597564