Skip to content

Remove assert from Http3Connection.SendAsync #74348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Remove assert from Http3Connection.SendAsync #74348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e06e8
Remove assert in System.Net.Http.Http3Connection.SendAsync
rzikm Aug 22, 2022
ae4c27b
Minor change
rzikm Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, lon
catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)
{
// This will happen if we aborted _connection somewhere and we have pending OpenOutboundStreamAsync call.
Debug.Assert(_abortException is not null);
// note that _abortException may be null if we closed the connection in response to a GOAWAY frame
throw new HttpRequestException(SR.net_http_client_execution_error, _abortException, RequestRetryType.RetryOnConnectionFailure);
}
finally
Expand Down Expand Up @@ -567,6 +567,10 @@ private async Task ProcessServerStreamAsync(QuicStream stream)
}
}
}
catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)
{
// ignore the exception, we have already closed the connection
}
catch (Exception ex)
{
Abort(ex);
Expand Down