Skip to content

Add dotnet8 feeds in main nuget.config #74101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Aug 17, 2022

Contributes to #63375
Contributes to #72112

@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63375
Addresses #72112

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

@carlossanlop carlossanlop mentioned this pull request Aug 17, 2022
7 tasks
@carlossanlop
Copy link
Contributor Author

This PR is fixing the following item from #72112:

Add the dotnet8 feeds to the NuGet.config

But I think I have to bring back the dotnet7 feeds because of the next item:

At a later point when all dependencies are available in the .NET 8 feeds, remove the .NET 7 feeds.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one comment, LGTM.

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@carlossanlop
Copy link
Contributor Author

Test failures are unrelated:

@carlossanlop carlossanlop changed the title Move dotnet7 feeds to dotnet8 in main nuget.config Add dotnet8 feeds in main nuget.config Aug 18, 2022
@carlossanlop carlossanlop merged commit 3db4524 into dotnet:main Aug 18, 2022
@carlossanlop carlossanlop deleted the NugetFeedDotnet8 branch August 18, 2022 03:00
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants