Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ObsoletedInOSPlatform attribute #73600

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Aug 9, 2022

We decided to rename ObsoletedInOSPlatformAttribute into ObsoletedOSPlatformAttribute to match with other platform names

Fixes #72970

CC @rolfbjarne @jeffhandley

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned buyaa-n Aug 9, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

We decided to rename ObsoletedInOSPlatformAttribute into ObsoletedOSPlatformAttribute to match with other platform names

Fixes #72970

CC @rolfbjarne @jeffhandley

Author: buyaa-n
Assignees: buyaa-n
Labels:

area-Meta

Milestone: -

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Aug 9, 2022

The failure unrelated and timed out not a real failure, doesn't seem worth for filing an issue:
['System.Data.OleDb.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@buyaa-n buyaa-n merged commit e117479 into dotnet:main Aug 9, 2022
@buyaa-n buyaa-n deleted the obsoleteosplatform branch August 9, 2022 16:15
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider naming of ObsoletedInOSPlatformAttribute
2 participants