JIT: Ensure correct alignment of CILJit singleton #73451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Aug 5, 2022
|
Linux arm failure is #73247 |
jkotas
approved these changes
Aug 5, 2022
jkotas
reviewed
Aug 5, 2022
| @@ -173,7 +161,8 @@ DLLEXPORT ICorJitCompiler* getJit() | |||
|
|
|||
| if (ILJitter == nullptr) | |||
| { | |||
| ILJitter = new (CILJitSingleton) CILJit(); | |||
| alignas(alignof(CILJit)) static char CILJitBuff[sizeof(CILJit)]; | |||
There was a problem hiding this comment.
Actually, is there a reason why we cannot just use a regular static CILJit singleton and just return its address here?
There was a problem hiding this comment.
I was not sure if there were concerns with the potential static constructor or ordering with jitStartup (there is a check that initialization has run before we construct this).
There was a problem hiding this comment.
CILJit constructor does close to nothing, it is just initializing the vtable. So the ordering is not a concern.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #73409