Enable inlining P/Invokes into try blocks with no catch or filter clauses #73032
Conversation
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| if (ExecutionManager::IsReadyToRunCode(((InlinedCallFrame*)pFrame)->m_pCallerReturnAddress)) | ||
| TADDR returnAddress = ((InlinedCallFrame*)pFrame)->m_pCallerReturnAddress; | ||
| #ifdef USE_PER_FRAME_PINVOKE_INIT |
There was a problem hiding this comment.
Is corinfo.h guaranteed to be included here to pickup this #define?
corinfo.h is JIT/EE interface so it does not need to be included globally.
There was a problem hiding this comment.
Is this one of those things we should set in the CMake files?
There was a problem hiding this comment.
I've explicitly included corinfo.h. Given that this behavior is effectively part of the JIT/EE contract (as one changing behavior will generally require corresponding work in the other to avoid crashes), I think corinfo.h is a good place for it to live.
…g c++ source files.
…f a catch handler is present.
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures are #73247 This is ready for another round of review |
|
Failures are #73247 and the timeouts that we've been seeing. |
…lter clauses (dotnet#73032)" This reverts commit 4c07f3d. We believe it is causing recent CI failures. See dotnet#73247
…ch or filter clauses (dotnet#73032)" (dotnet#73551)" This reverts commit 2a14280.
ghost
locked as resolved and limited conversation to collaborators
Contributes to #70109