-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/6.0] CreateSymbolicLink PInvoke retval must be marshalled as U1 #73004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] CreateSymbolicLink PInvoke retval must be marshalled as U1 #73004
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #69150 Customer ImpactCustomers who create Symbolic Links using the new APIs introduced in 6.0 will face silent failures when Developer mode is disabled in Windows settings. File.Create("my-file.txt";).Dipose();
// Having developer mode disabled on Windows, this will silently fail.
FileSystemInfo linkInfo = File.CreateSymbolicLink("my-link", "my-file.txt");
Console.WriteLine($"Link exsts: {linkInfo.Exists}"); // prints false when it should’ve thrown above.TestingCustomer confirmed and reported that issues is fixed, and it no longer fails silently. RiskLow, changes are minimal.
|
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.CreateSymbolicLink.cs
Show resolved
Hide resolved
|
Failing runtime leg is an error on System.Diagnostics.Tests.PerformanceCounterTests, filed #73019. runtime-staging shows many errors on |
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tactics approved.
Correct milestone applied.
CI failures are unrelated.
Area owner signed off.
No OOB package authoring changes needed (affecting installer and Common code).
Ready to merge. ![]()
Backport of #69150
Customer Impact
Customer reported. Customers who create Symbolic Links using the new APIs introduced in 6.0 will face silent failures when Developer mode is disabled in Windows settings.
Testing
Customer confirmed and reported that issues is fixed, and it no longer fails silently.
The change has been in-place for months on .NET 7 with no failures involved.
Risk
Low, changes are minimal and self-evidently correct.