Skip to content

[wasm] re-try downloading assets #72933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2022
Merged

[wasm] re-try downloading assets #72933

merged 4 commits into from
Aug 2, 2022

Conversation

pavelsavara
Copy link
Member

Fixes #68992

@pavelsavara pavelsavara added this to the 7.0.0 milestone Jul 27, 2022
@pavelsavara pavelsavara requested review from radical and kg July 27, 2022 11:15
@pavelsavara pavelsavara self-assigned this Jul 27, 2022
@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68992

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

This was referenced Jul 27, 2022
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

Make max_parallel_downloads configurable. In case that blazor cache has it's own throttling.

@pavelsavara pavelsavara marked this pull request as ready for review July 28, 2022 18:32
@pavelsavara pavelsavara requested a review from lewing as a code owner July 28, 2022 18:32
@runfoapp runfoapp bot mentioned this pull request Jul 29, 2022
Closed
@pavelsavara
Merge branch 'main' into wasm_asset_download_retry
b3f9241 
# Conflicts:
#	src/mono/wasm/runtime/startup.ts
@radical
Copy link
Member

radical commented Aug 1, 2022

Works fine on codespaces! 🥳

@pavelsavara
Copy link
Member Author

@radical please review

@pavelsavara pavelsavara merged commit c4bb28f into dotnet:main Aug 2, 2022
@pavelsavara pavelsavara changed the title [wasm][draft] re-try downloading assets [wasm] re-try downloading assets Aug 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2022
@pavelsavara pavelsavara deleted the wasm_asset_download_retry branch November 29, 2022 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@radical radical Awaiting requested review from radical

@kg kg Awaiting requested review from kg

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] startup.ts has a fixed "max parallel downloads", but that can fail
3 participants
@pavelsavara @radical @maraf